Close avio object *before* encode destruction. And flush, too. #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Closed
|
😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 https://github.com/pytorch/torchcodec/actions/runs/16241951867/job/45859651025?pr=773 |
scotts
reviewed
Jul 23, 2025
| @@ -99,8 +99,18 @@ AVSampleFormat findBestOutputSampleFormat(const AVCodec& avCodec) { | |||
| } // namespace | |||
|
|
|||
| AudioEncoder::~AudioEncoder() { | |||
| if (avFormatContext_ && avFormatContext_->pb && !avioContextHolder_) { | |||
| avio_close(avFormatContext_->pb); | |||
| close_avio(); | |||
There was a problem hiding this comment.
Nite: closeAVIO() for consistency.
scotts
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Failed to open input bufferaren't resolved as they were visible in https://github.com/pytorch/torchcodec/actions/runs/16238309871/job/45851804069?pr=757.So #724 is still a problem, and #755 wasn't a proper fix.
I hope this one is the one. It does 2 things:
avio_close()at the end ofencode(). Not just when the encoder is destructed. That makes sense.avio_flush(), which was potentially needed. I'm not entirely sure, but it's probably needed. Or at least it's fairly clear that callingavio_close()isn't enough anyway, because we are seeing the error not just when relying on FFmpeg's default avio object, but also when usingto_tensor(): https://github.com/pytorch/torchcodec/actions/runs/16238309871/job/45851804069?pr=757.